Skip to content

[Version-unspecific] Ignore txs for LockTime only when a future height

Multipartite requested to merge Multi/ignore-future-locktime-only into develop

[Version-unspecific]

Intended to close #1516 (closed)
'Mainstream UTXO wallets set (memoless Savers deposit) LockTime to the current block by default, but THORChain ignores any LockTime greater than 0'.

I note in TestFetchTxs the change of fetched txs number from 13 to 102,
and the Merge Request in which they were previously changed from 102 to 13: !1851 (merged)
'Ensure the UTXO to asgard is spendable'.

As an example,
https://gitlab.com/thorchain/thornode/-/blob/v1.108.0/test/fixtures/btc/block_verbose.json
has only 19 instances of
"locktime": 0,
and 81 instances of
"locktime": 1696760,
.
However, here it shows that for the block in question
"height": 1696761,
, meaning that a LockTime set to one block earlier (1696760) does not make these unspendable (I believe).

Merge request reports