Skip to content

[Version-unspecific] Don't increment sequence number for failed tx commit.Code 6

Multipartite requested to merge Multi/code-6-no-seqNum-increment into develop

[Version-unspecific]

Intended to close #1505
'Is it correct or not to increment sequence number for commit.Code 6?'.

My current impression is that there is no reason for commit.Code 6 to increment the sequence number while all other codes greater than 0 do not.

For context, note that (my impression is that) returning nil for commit.Code 6 is so that THORNode does not retry (endlessly?) a broadcast that cannot succeed.

Merge request reports