[chain] Binance Smart Chain (Bifrost Refactor Avalanche -> EVM)

My familiarity with EVM chain behaviour is low, but asking whether certain sentences here could be relevant for this MR:

Nor is Ethereum Virtual Machine (EVM) compatibility a useful factor in de-risking a chain’s adoption. EVM compatibility means that (in theory) applications written for Ethereum’s virtual machine will run on any other chain making that claim. Theory doesn’t always match reality exactly, however. As a result, EVM compatibility may actually increase risk.

EVM compatibility is not perfect and the implementation on each chain is slightly different. While this can definitely make it simpler to deploy new smart contracts on a different chain, they may behave differently in a fully “compatible” environment and the claim of compatibility may increase risk that people deploy without careful consideration. We often encounter novel errors when moving smart contracts from bitcoineum testnets to the mainnet.

To what extent does this/{Future Work} intend to consolidate THORChain Go code for EVM (Ethereum/Avalanche/BSC?) chains?
|
(I speculate that many identical functions could be consolidated,
but wish to know whether such a consolidation attempt would also require consolidation of non-identical functions,
and whether differences between such functions could be necessary chain-specific differences.
|
In essence, undesirable if a large consolidation attempt went to waste because at the last step it turned out to not be doable.)

Thank you for your time.

added 1 commit

18684b1b - [bifrost] Refactor Avalanche Client -> EVM for Binance Smart Chain

Compare with previous version

added 1 commit

b38d42f7 - fix smoke dependency

Compare with previous version

mentioned in merge request !2773 (closed)

resolved all threads

approved this merge request

Needs a manual rebase. Excited to review and get merged!

added 5 commits

b38d42f7...31b20e66 - 3 commits from branch develop
6b75c992 - [bifrost] Refactor Avalanche Client -> EVM for Binance Smart Chain
2c8c5c52 - rebase cleanup

Compare with previous version

added 1 commit

e0917950 - smoke

Compare with previous version

added 4 commits

085d644a - 1 commit from branch develop
a6adcdc0 - [bifrost] Refactor Avalanche Client -> EVM for Binance Smart Chain
ee81539d - rebase cleanup
d0edc9d6 - smoke

Compare with previous version

added 5 commits

d0edc9d6...781877f5 - 2 commits from branch develop
e8c50b24 - [bifrost] Refactor Avalanche Client -> EVM for Binance Smart Chain
d0b4df0b - rebase cleanup
378af107 - smoke

Compare with previous version

removed milestone %Release-1.109.0

closed

added auto-closed-reopen-if-needed label

reopened

removed auto-closed-reopen-if-needed label

changed milestone to %Release-1.110.0

changed milestone to %Release-1.111.0

approved this merge request

Needs manual rebase, will reapprove right after.

added 36 commits

378af107...3a5d01f8 - 34 commits from branch develop
0b58b028 - [chain] Binance Smart Chain (Bifrost Refactor Avalanche -> EVM)
730f038d - add router addresses

Compare with previous version

marked this merge request as draft

changed title from [bifrost] Refactor Avalanche Client -> EVM for Binance Smart Chain to Draft: [chain] Binance Smart Chain (Bifrost Refactor Avalanche -> EVM)