Skip to content
Snippets Groups Projects

[midgard] Add Empty Fields to Withdraw Events on Pool Suspend

Merged Ursa (9R) requested to merge ursa/suspend-events into develop

Midgard drops events that do not contain the empty field, and since the withdraw events emitted during pool cycle do not have an originating transaction they were ignored. This is the cause of the current discrepancy on state for the ETH.HEGIC pool - @HooriRn is making corresponding Midgard corrections.

I'm not sure what makes most sense, but I also update the basis points on the withdraw event to 10000 since the position is close, but left the emitted RUNE and asset as 0 since nothing is sent back to LPs when the pool is suspended.

Merge request reports

Merge request pipeline #806206012 passed

Merge request pipeline passed for 9ba66e76

Test coverage 55.50% (0.00%) from 1 job
Deployed to integ‎ration‎ 2 years ago
Approved by

Merged by PlutoPluto 2 years ago (Mar 14, 2023 7:05pm UTC)

Merge details

  • Changes merged into develop with d3ee5c35 (commits were squashed).
  • Deleted the source branch.

Pipeline #806234103 passed

Pipeline passed for d3ee5c35 on develop

Test coverage 55.50% (0.00%) from 1 job
Deployed to integ‎ration‎ 2 years ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading