[Refactor] No keeper within pool manager struct #unsafe

[Version-unspecific]

This has (following a merge conflict) been budded into its own MR from !2600 (merged),
which was originally budded from !2579 (closed).

mentioned in merge request !2600 (merged)

approved this merge request

changed milestone to %Release-1.99.0

Much smaller diff, thank you! And thank you once again for dead variable removal.

approved this merge request

Thank you for cleaning up my garbage

approved this merge request

added 12 commits

• e0bfc205...6840732c - 11 commits from branch thorchain:develop
• 2e498682 - [Refactor] No keeper within pool manager struct

Compare with previous version

@Multipartite looks like the v98 pool manager was improperly archived. Please copy + paste with no changes.

see failed lint https://gitlab.com/thorchain/thornode/-/jobs/3272238969

My understanding at this moment is that it was archived in a way consistent with the previous structure and not with !2646 (merged) (!2646 (merged) being a refactor); I may misunderstand your description, but for the moment will aim to add a commit which refactors the v98 archive.
[Edit: Rereading.]
Second edit: For the moment I have added #unsafe to the MR title and scheduled a pipeline, which I think should stop the lint objection to the different-version function names being refactored; if it still fails I will contemplate it after sleep.

This is a good test of the new linter, and of the #unsafe title bypass

Indeed! CCing @ursa9r for the below notes:

I note that the pipeline I triggered from the branch's repository before sleep failed
( https://gitlab.com/Multipartite/thornode/-/pipelines/685180149 )
and that the merge request shows a passed pipeline from me 4 days ago and from Pluto four hours ago.
( !2646 (merged) )
The passed Pluto pipeline has both the failed and passed lint; I previously noticed I didn't see a way to manually rerun Pluto's pipeline's lint.

Now testing the 'Run pipeline' button in
!2646 (merged)

it looks as though that does work (without needing to trigger it with a git push), and that that's what I should have done instead of starting one from
https://gitlab.com/Multipartite/thornode/-/pipelines
.

changed title from [Refactor] No keeper within pool manager struct to [Refactor] No keeper within pool manager struct #unsafe

added 3 commits

• 2e498682...5a1dcc36 - 2 commits from branch thorchain:develop
• 0fdc9a50 - [Refactor] No keeper within pool manager struct

Compare with previous version

enabled an automatic merge when the pipeline for 0fdc9a50 succeeds

merged