Skip to content
Snippets Groups Projects

[V108-specific] Update actions GasRate

Merged Multipartite requested to merge Multipartite/thornode:update-actions-GasRate into develop

[V108-specific]

Intended to close #1426 (closed)
'Unemitted outbound events due to MaxGas not updated in ObservedTxInVoter's actions'.


Additional comment:
manager_txout_current.go's EndBlock's
if len(tx.MaxGas) == 0 || maxGas.Amount.GT(tx.MaxGas[0].Amount) {
condition for MaxGas updating (and not for GasRate updating) is (if I remember correctly) the underlying reason for keeping the updates separate instead of folding them into a single function.

(Discussion is welcome.)

Edited by Multipartite

Merge request reports

Merge request pipeline #814904242 passed

Merge request pipeline passed for 034d2f03

Test coverage 55.60% (0.10%) from 1 job
Deployed to integ‎ration‎ 2 years ago
Approved by
Test summary results are being parsed

Merged by Asmund THORSecAsmund THORSec 2 years ago (Mar 22, 2023 7:55pm UTC)

Merge details

  • Changes merged into develop with 29060321 (commits were squashed).
  • Did not delete the source branch.
  • Auto-merge enabled

Pipeline #814921189 passed

Pipeline passed for 29060321 on develop

Test coverage 55.60% (0.10%) from 1 job
Deployed to integ‎ration‎ 2 years ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading