Skip to content

[fix] Retiring Vault Outbound Selection

Ursa (9R) requested to merge ursa/retiring-outbounds into develop

There was a case for the outbound at https://viewblock.io/thorchain/tx/E1B8CE5C3B0ABFB98A3CD8D35F773B37759415CBE259DD61D3051DCE0EDF1AD3 where no active asgards with UOS had ETH, so they were skipped (https://gitlab.com/thorchain/thornode/-/blob/develop/x/thorchain/manager_txout_current.go#L213):

$ tci vaults --height 7135438 status --asset ETH.ETH asgard
                       status  status_since       ETH.ETH
pub_key
thorpub...h457  RetiringVault       7134913  100657740120
thorpub...vzyy  RetiringVault       7134913   35053590067
thorpub...fzef  RetiringVault       7134913  146384033576
thorpub...965n  RetiringVault       7134913  196078245080
thorpub...j8uj  RetiringVault       7134913  110548066101
thorpub...z2lf    ActiveVault       7134913  147095647073
thorpub...qe5v    ActiveVault       7134913           NaN
thorpub...yxy5    ActiveVault       7134913           NaN
thorpub...xdta    ActiveVault       7134913     193083000
thorpub...5qcf    ActiveVault       7134913           NaN

$ tci vaults --height 7135438 status --asset ETH.UOS asgard
                       status  status_since ETH.UOS-0XD13C7342E1EF687C5AD21B27C2B65D772CAB5C8C
pub_key
thorpub...h457  RetiringVault       7134913                                     15570897440000
thorpub...vzyy  RetiringVault       7134913                                     19269339780000
thorpub...fzef  RetiringVault       7134913                                      3134358040000
thorpub...965n  RetiringVault       7134913                                     21857752820000
thorpub...j8uj  RetiringVault       7134913                                     22773775220000
thorpub...z2lf    ActiveVault       7134913                                                NaN
thorpub...qe5v    ActiveVault       7134913                                                NaN
thorpub...yxy5    ActiveVault       7134913                                      4817334940000
thorpub...xdta    ActiveVault       7134913                                                NaN
thorpub...5qcf    ActiveVault       7134913                                     15834195850000

Since the length of the outputs was 0 because the outbound could not be satisfied at all by an active vault, attempting to satisfy via the retiring vaults was skipped.

Merge request reports