[ADD] Enable Linters and Gofumpt

Ursa (9R)requested to merge
ursa/enable-linters into develop

This primarily enables a handful of additional linters in golangci - these will only get applied by trunk on new changes, existing code that breaks them will be sampled and shown as a warning but not fail the lint target. I'll go through and fix warnings in smaller batches since there are many, this pass just enables remaining linters and fixes the lint-pre target.

Changes

  • Add new golangci linters
  • Apply gofumpt changes and fix the lint-pre target
  • Update the protob target to use go install instead of go get to avoid modifying go.mod - this was why those showed changed after make build
  • Prefix UnavailableBlock and FailOutputMatchCriteria with Err to satisfy the linter since it failed after gofumpt modified those lines
Edited by Heimdall

Merge request reports