[ADD] Chain Gas Metrics

Ursa (9R)requested to merge
ursa/gas-metrics into develop

This adds the following chain metrics for gas price updates per Discord request (cc @Orion9R):

  • Change count
  • Suggested price when there is a difference between the suggested value from the client or last block heuristic
  • Current price

I added these metrics following the existing pattern to create a new metric name per chain for the initial pass, but I would like to understand the reasoning for structuring these metrics in this form - were there specific problems with naming these as purely the global metric name and passing a label for the chain? IMO that would be the more idiomatic approach and make the Prometheus queries for charts and alerts much simpler. Additionally there are a lot of stutters in these metrics - for example block_scanner_BCH_block_scanner_BCH_block_no_tx_out should be simply block_scanner_no_tx_out with a label chain=bch. If others are in agreement I can work separately on a deeper refactor of all metrics in bifrost.

Earmarks

  • Remove dead common.UpdateGasPrice
  • Remove unused wait group from metrics.Metrics
Edited by Heimdall

Merge request reports