Skip to content

[security fix] Unbond doesn't add to bond if refund bond isn't sucessful

Son of Odin requested to merge unbond-bug into master

A security hole was discovered where an attacker can send a transaction to THORChain using the UNBOND memo, and specifying 1 rune or less at the amount to unbond, while sending in any amount of rune into the network (which gets added to their bond). Because the request to send back 1 rune isn't enough to pay for the network fee, this triggered a refund of that rune that was sent into the network, to be sent back to the sender.

This allows a node operator to send in 10k rune (for example), get a refund of 10k rune, while also increasing their bond by 10k at the same time. Allowing them to then steal 10k rune from the network by a correctly formatted second UNBOND memo. A node operator could drain the network of all rune, if unchecked.

Merge request reports