Quote End Point Issues
-
Quote End Point should return shortened asset names in the memo. !3396 (merged) Should have implemented this, @Multipartite. Memos returned by the quote endpoint are used directly in interfaces.
e.g.
=:THOR.RUNE:thor1kzpfhzvakahg4x0fvr5fzfn8s4ku3cjttyseec
should be=:r:thor1kzpfhzvakahg4x0fvr5fzfn8s4ku3cjttyseec.
-
'recommended_min_amount_in' returns a very high amount. https://thornode.ninerealms.com/thorchain/quote/swap?from_asset=BTC.BTC&to_asset=THOR.RUNE&amount=475964&destination=thor1kzpfhzvakahg4x0fvr5fzfn8s4ku3cjttyseec gives 2544000 which is 0.025 BTC, or approx $2K when the inbound fee is only $35.
recommended_min_amount_in
should reflect a realistic amount given all the fees."fees": { "asset": "THOR.RUNE", "affiliate": "0", "outbound": "2000000", "liquidity": "26430", "total": "2026430", "slippage_bps": 0, "total_bps": 3 }, "slippage_bps": 0, "streaming_slippage_bps": 0, "expiry": 1713837323, ... "recommended_min_amount_in": "2544000", "memo": "=:THOR.RUNE:thor1kzpfhzvakahg4x0fvr5fzfn8s4ku3cjttyseec",
FTR, mempool.space is showing 230 sat/vB for very high priority. Inbound Address is showing 415 satsperbyte. Big difference for the standard rate.
-
Fuzzy logic assets abbreviations should be returned to quote memos, as per https://dev.thorchain.org/concepts/memo-length-reduction.html#asset-abbreviations. E.g.
ETH.USDT
instead ofETH.USDT-0xdac17f958d2ee523a2206206994597c13d831ec7
as there is no name conflict withETH.USDT.
I can't think where there is a name conflict using chain.asset notation when using mainnet.