[Node] Logging events displayed or not displayed for different commands.
Summary
There are some log events that under the same circumstances are displayed when tezos-node config
is run, but are not displayed when tezos-node run
is. For instance Node_config_file.Event.all_rpc_allowed
event added with !3219 (merged) is raised in reaction to the user selecting --allow-all-rpc
option to warn about possible consequences. The function where this event is raised (Node_config_file.update
) is called for both config
and run
commands (verified using debug prints), but the warning is only displayed for tezos-node config
. There might be more events like this.
Expected behavior
The warning should be displayed in both tezos-node config
and tezos-node run
.
Actual behavior
The warning is displayed in tezos-node config
but not in tezos-node run
.
Steps to reproduce
Checkout !3219 (merged) if it wasn't merged yet. Compile the code and run:
$ ./tezos-node config show --allow-all-rpc localhost
And observe the line:
Jul 28 09:56:32.410 - node.main: FULL access to RPC enabled; this is very risky. (addresses = localhost)
displayed before the actual config. The same line is shown in other instances of tezos-node config
command.
Now run
$ ./tezos-node run --allow-all-rpc localhost
And observe the log not appearing.