Skip to content

install_repository: do not exclude src.rpm from downloading

Miroslav Vadkerti requested to merge TFT-2206 into main

As it turns out, src.rpm was excluded even from download during filtering for latest packages.

Next to it make tests more sane:

  1. As I found out, rpm package-install-1.0.1.rpm is not a rpm NEVRA and it gets parsed like this by splitFilename function:

    In [1]: from gluetool_modules_framework.libs.artifacts import splitFilename
    In [2]: splitFilename('package-install-1.0.1.rpm')
    Out[2]: ('package', 'install', '1.0', '', '1')

    Note that parsed out RPM name is package, which is obviously wrong.

  2. Use side_effect to provide separate stdout return values when mocking the run command calling dnf, to make it more sane. Previously each call was returning the same list of packages, bringing in more confusion to the tests.

Resolves TFT-2206

Signed-off-by: Miroslav Vadkerti mvadkert@redhat.com

Closes TFT-2206

Merge request reports