Skip to content

Fix bug in setting serialization mode

Carlos Pascual requested to merge github/fork/cpascual/concurrent into develop

TaurusModel's logic for setting the serialization mode is wrong due to a tabulation problem. This leads to TaurusDevices always being initialized with serialization mode 'Serial', ignoring the mode set in the Manager (by default, 'Concurrent'). Fix the tabulation issue and restore the intended logic.

Warning: be aware that because the Concurrent mode was in practice not set until now (in spite of being the intended situation), some code may not have been properly tested under Concurrent serialization mode and therefore potentially bugs which have been hidden may now suface.

The problem can be seen with the following code (it prints Concurrent=False unless this patch is applied):

import taurus
m = taurus.Manager()
m.setSerializationMode(taurus.core.TaurusSerializationMode.Concurrent)
a = taurus.Attribute('sys/tg_test/1/double_scalar')
print "Concurrent=", a._serialization_mode==taurus.core.TaurusSerializationMode.Concurrent

Merge request reports