Skip to content
Snippets Groups Projects

fix: protect taurusgui against lack of PyQtWebEngine

Merged Zbigniew Reszela requested to merge reszelaz/taurus:taurusgui_manual_no_webengine into develop

Manual panel's widget is None when PyQtWebEngine is not installed. Avoid exception on closing GUI by only propagating the closeEvent to the panel's widget when it exists.

MainThread     ERROR    2022-01-10 14:03:58,500 LogExceptHook: Unhandled exception:
Traceback (most recent call last):
  File "c:\users\vagrant\appdata\local\programs\python\python38\lib\site-packages\taurus\qt\qtgui\taurusgui\taurusgui.py", line 426, in closeEvent
    panel.widget().closeEvent(event)
AttributeError: 'NoneType' object has no attribute 'closeEvent'

Merge request reports

Pipeline #444845548 failed

Pipeline failed for 11dd956d on reszelaz:taurusgui_manual_no_webengine

Deployed to Docs‎-dev‎ 3 years ago
Approval is optional

Merged by Carlos PascualCarlos Pascual 3 years ago (Jan 11, 2022 5:33pm UTC)

Merge details

  • Changes merged into master with 30c59fe6 (commits were squashed).
  • Deleted the source branch.

Pipeline #445993595 passed

Pipeline passed for 30c59fe6 on develop

Deployed to Docs‎-dev‎ 3 years ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading