Skip to content

Fix import error in TaurusGraphicScene.selectGraphicItem

Carlos Pascual requested to merge c-p/taurus:fix_jdraw_parser_import into develop

The refactoring of imports in !1199 (merged) introduced a regression (an ImportError) in TaurusGraphicScene.selectGraphicItem. Fix it by correcting the import statement.

Also refactor some internal jdraw-related imports for consistency with the official API.

Note: the import error can be easily reproduced with:

$ taurus gui example01   
(...)

MainThread     INFO     2021-08-25 19:11:03,797 TaurusGui: MainWindow settings restored
MainThread     ERROR    2021-08-25 19:11:03,835 LogExceptHook: Unhandled exception:
Traceback (most recent call last):
  File "/home/cpascual/src/taurus/lib/taurus/qt/qtgui/graphic/jdraw/jdraw_view.py", line 196, in selectGraphicItem
    self.scene().selectGraphicItem(item_name)
  File "/home/cpascual/src/taurus/lib/taurus/qt/qtgui/graphic/taurusgraphic.py", line 592, in selectGraphicItem
    from taurus.qt.qtgui.graphic import jdraw_parser
ImportError: cannot import name 'jdraw_parser' from 'taurus.qt.qtgui.graphic' (/home/cpascual/src/taurus/lib/taurus/qt/qtgui/graphic/__init__.py)

(...)
Edited by Carlos Pascual

Merge request reports