Skip to content
Snippets Groups Projects
Select Git revision
0 results

compatible_since.go

  • Hao Hu's avatar
    20a77d8b
    fix(renovate)!: prioritise `packageName` over `depName` · 20a77d8b
    Hao Hu authored and Jamie Tanna's avatar Jamie Tanna committed
    When deriving the underlying `package_name` for the Renovate datasource,
    we've been using `depName` from the underlying package data exports.
    
    For most cases, this gives us exactly what we want, but in some cases,
    this presents a different a different `package_name`, as the `depName`
    is generally intended to be for the "pretty" name for a package.
    
    For instance:
    
        {
          "depType": "plugin",
          "depName": "org.sonarqube",
          "packageName": "org.sonarqube:org.sonarqube.gradle.plugin",
          "currentValue": "3.3",
          "datasource": "maven",
          "packageScope": "org.sonarqube",
          "currentVersion": "3.3",
          "isSingleVersion": true,
          "fixedVersion": "3.3"
        }
    
    To correct this, we can make sure we now prioritise `packageName`.
    
    This requires a bump of `compatible_since`, as this is a change to the
    way that the data is derived, and may incur breakages to existing users'
    queries.
    20a77d8b
    History
    fix(renovate)!: prioritise `packageName` over `depName`
    Hao Hu authored and Jamie Tanna's avatar Jamie Tanna committed
    When deriving the underlying `package_name` for the Renovate datasource,
    we've been using `depName` from the underlying package data exports.
    
    For most cases, this gives us exactly what we want, but in some cases,
    this presents a different a different `package_name`, as the `depName`
    is generally intended to be for the "pretty" name for a package.
    
    For instance:
    
        {
          "depType": "plugin",
          "depName": "org.sonarqube",
          "packageName": "org.sonarqube:org.sonarqube.gradle.plugin",
          "currentValue": "3.3",
          "datasource": "maven",
          "packageScope": "org.sonarqube",
          "currentVersion": "3.3",
          "isSingleVersion": true,
          "fixedVersion": "3.3"
        }
    
    To correct this, we can make sure we now prioritise `packageName`.
    
    This requires a bump of `compatible_since`, as this is a change to the
    way that the data is derived, and may incur breakages to existing users'
    queries.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.