Skip to content

Fix some and silence some C++ compiler warnings

Thomas Braun requested to merge bugfix/fix-cpp-warnings into develop

I've fixed some of the compiler warnings and also silenced the numpy warnings. The fixed compiler warnings are pretty straight forward.

There is one compiler warning still present which I'm not sure how to solve.

/home/firma/devel/pytango/ext/device_proxy.cpp: In function ‘int PyDeviceProxy::subscribe_event_global(boost::python::api::object, Tango::EventType, boost::python::api::object, bool)’:
/home/firma/devel/pytango/ext/device_proxy.cpp:586:5: warning: control reaches end of non-void function [-Wreturn-type]                                                
     }
     ^

It is this code https://gitlab.com/tango-controls/pytango/-/blob/develop/ext/device_proxy.cpp#L570-587 here.

The solution without understanding the code better would be to just throw something after the if block as we did not succeeded in subscribing. I also don't see think that cppTango subcsribe_event either fails without throwing an exception, so the returned event id will always be correct.

Edited by Anton Joubert

Merge request reports