Skip to content

Fix some compilation warnings

Reynald Bourtembourg requested to merge github/fork/bourtemb/fix_warnings-t9lts into tango-9-lts

This PR was created to fix the following compilation warnings observed when compiling in Debug mode with gcc 6.3.0:

cppapi/client/zmqeventconsumer.cpp: In member function ‘void Tango::ZmqEventConsumer::push_zmq_event(std::__cxx11::string&, unsigned char, zmq::message_t&, bool, const DevULong&)’: cppapi/client/zmqeventconsumer.cpp:1975:10: warning: variable ‘first_search_succeed’ set but not used [-Wunused-but-set-variable] bool first_search_succeed = false; ^~~~~~~~~~~~~~~~~~~~ cppapi/client/zmqeventconsumer.cpp: In member function ‘void Tango::ZmqEventConsumer::set_socket_hwm(size_t)’: cppapi/client/zmqeventconsumer.cpp:3514:12: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if(hwm != current_sub_hwm) ~~~~^~~~~~~~~~~~~~~~~~

In file included from cpp_test_suite/cxxtest/runner.cpp:17:0: cpp_test_suite/cxxtest/include/cxxtest/TestTracker.h:112:2: warning: extra ‘;’ [-Wpedantic] }; ^

In file included from cpp_test_suite/cxxtest/include/cxxtest/ValueTraits.h:344:0, from cpp_test_suite/cxxtest/include/cxxtest/TestSuite.h:13, from cpp_test_suite/cxxtest/include/cxxtest/RealDescriptions.h:9, from cpp_test_suite/cxxtest/include/cxxtest/TestRunner.h:11, from cpp_test_suite/cxxtest/runner.cpp:18: cpp_test_suite/cxxtest/include/cxxtest/StdValueTraits.h:225:2: warning: extra ‘;’ [-Wpedantic] }; ^ In file included from cpp_test_suite/cxxtest/runner.cpp:18:0: cpp_test_suite/cxxtest/include/cxxtest/TestRunner.h:122:2: warning: extra ‘;’ [-Wpedantic] }; ^ In file included from cpp_test_suite/cxxtest/include/cxxtest/TangoPrinter.h:15:0, from cpp_test_suite/cxxtest/runner.cpp:21: cpp_test_suite/cxxtest/include/cxxtest/ErrorFormatter.h:279:2: warning: extra ‘;’ [-Wpedantic] };

In file included from cpp_test_suite/cxxtest/include/cxxtest/Root.cpp:9:0, from cpp_test_suite/cxxtest/runner.cpp:1965: cpp_test_suite/cxxtest/include/cxxtest/Descriptions.cpp:56:2: warning: extra ‘;’ [-Wpedantic] }; ^ In file included from cpp_test_suite/cxxtest/include/cxxtest/Root.cpp:12:0, from cpp_test_suite/cxxtest/runner.cpp:1965: cpp_test_suite/cxxtest/include/cxxtest/LinkedList.cpp:170:2: warning: extra ‘;’ [-Wpedantic] }; ^ In file included from cpp_test_suite/cxxtest/include/cxxtest/Root.cpp:14:0, from cpp_test_suite/cxxtest/runner.cpp:1965: cpp_test_suite/cxxtest/include/cxxtest/TestSuite.cpp:136:2: warning: extra ‘;’ [-Wpedantic] }; ^ In file included from cpp_test_suite/cxxtest/include/cxxtest/Root.cpp:15:0, from cpp_test_suite/cxxtest/runner.cpp:1965: cpp_test_suite/cxxtest/include/cxxtest/TestTracker.cpp:246:2: warning: extra ‘;’ [-Wpedantic] }; ^ In file included from cpp_test_suite/cxxtest/include/cxxtest/Root.cpp:16:0, from cpp_test_suite/cxxtest/runner.cpp:1965: cpp_test_suite/cxxtest/include/cxxtest/ValueTraits.cpp:138:2: warning: extra ‘;’ [-Wpedantic] }; ^

cpp_test_suite/cpp_test_ds/fwd_ds/main.cpp:49:22: warning: extra ‘;’ [-Wpedantic] DECLARE_CRASH_HANDLER; ^

cpp_test_suite/cpp_test_ds/TypeCmds.cpp: In member function ‘virtual CORBA::Any* IOString::execute(Tango::DeviceImpl*, const CORBA::Any&)’: cpp_test_suite/cpp_test_ds/TypeCmds.cpp:616:1: warning: control reaches end of non-void function [-Wreturn-type] } ^

Merge request reports