make go-ci-lint happy

The golang-ci-lint CI job was failing in !551 (merged) but because it has allow_failure: true when the MR is in Draft this did not prevent the MR from merging.

Here is the failures that we now get, and which block any merge in this reoo: https://gitlab.com/sylva-projects/sylva-elements/sylva-units-operator/-/pipelines/2382905947

This MR fixes these failures.

For linter failure SA1019 the workaround is a heavier refactoring...

test/e2e/e2e_suite_test.go:220:23: SA1019: client.Apply is deprecated: Use client.Client.Apply() and client.Client.SubResource("subrsource").Apply() instead. (staticcheck)
		ctx, sourceService, client.Apply, client.ForceOwnership, client.FieldOwner("e2e-test-client")); err != nil {

So for this one I'm filing a follow-up issue (#94 (closed)).

Edited by Thomas Morin

Merge request reports

Loading
Loading