Revisit error management to provide details on transient errors

Francois Eleouetrequested to merge
add-error-details into main

closes #51 (closed)

Stop using generic errors that were hiding the underlying error.

We define a new error that allows to instruct whether the controller should requeue or not.

The requeue behavior is also revisited to only requeue when it is required (many errors require a configuration change to be fixed, requeueing is useless in such cases.

With proposed changed, when some valuesFrom repo is not yet ready, we'll have following status:

❯ k get sur -A 
NAMESPACE             NAME          AGE     READY   STATUS
sylva-units-preview   sylva-units   3h55m   False   OCIRepository sample-values-repo used in valuesFrom is not ready

Instead of current generic message:

❯ k get sur -A
NAMESPACE             NAME          AGE   READY   STATUS
sylva-units-preview   sylva-units   53s   False   the SylvaUnitsRelease is not yet ready
Edited by Francois Eleouet

Merge request reports