[provider-id-blacklist controller] - Fix configmaps rbac rules and use provideridShort as key in the CM

First commit !5 (e6ed5953) fix the following issue (fix the rbac rules related to configmap):

2025-08-05T10:08:39Z	ERROR	controller-runtime.cache.UnhandledError	Failed to watch	{"reflector": "pkg/mod/k8s.io/client-go@v0.33.0/tools/cache/reflector.go:285", "type": "*v1.ConfigMap", "error": "failed to list *v1.ConfigMap: configmaps is forbidden: User \"system:serviceaccount:misc-controllers-suite-system:misc-controllers-suite-controller-manager\" cannot list resource \"configmaps\" in API group \"\" at the cluster scope"}
k8s.io/apimachinery/pkg/util/runtime.logError
	/go/pkg/mod/k8s.io/apimachinery@v0.33.0/pkg/util/runtime/runtime.go:226
k8s.io/apimachinery/pkg/util/runtime.handleError
	/go/pkg/mod/k8s.io/apimachinery@v0.33.0/pkg/util/runtime/runtime.go:217
k8s.io/apimachinery/pkg/util/runtime.HandleErrorWithContext
	/go/pkg/mod/k8s.io/apimachinery@v0.33.0/pkg/util/runtime/runtime.go:203
k8s.io/client-go/tools/cache.DefaultWatchErrorHandler
	/go/pkg/mod/k8s.io/client-go@v0.33.0/tools/cache/reflector.go:200
k8s.io/client-go/tools/cache.(*Reflector).RunWithContext.func1
	/go/pkg/mod/k8s.io/client-go@v0.33.0/tools/cache/reflector.go:360
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1
	/go/pkg/mod/k8s.io/apimachinery@v0.33.0/pkg/util/wait/backoff.go:233
k8s.io/apimachinery/pkg/util/wait.BackoffUntilWithContext.func1
	/go/pkg/mod/k8s.io/apimachinery@v0.33.0/pkg/util/wait/backoff.go:255
k8s.io/apimachinery/pkg/util/wait.BackoffUntilWithContext
	/go/pkg/mod/k8s.io/apimachinery@v0.33.0/pkg/util/wait/backoff.go:256
k8s.io/apimachinery/pkg/util/wait.BackoffUntil
	/go/pkg/mod/k8s.io/apimachinery@v0.33.0/pkg/util/wait/backoff.go:233
k8s.io/client-go/tools/cache.(*Reflector).RunWithContext
	/go/pkg/mod/k8s.io/client-go@v0.33.0/tools/cache/reflector.go:358
k8s.io/client-go/tools/cache.(*controller).RunWithContext.(*Group).StartWithContext.func3
	/go/pkg/mod/k8s.io/apimachinery@v0.33.0/pkg/util/wait/wait.go:63
k8s.io/apimachinery/pkg/util/wait.(*Group).Start.func1
	/go/pkg/mod/k8s.io/apimachinery@v0.33.0/pkg/util/wait/wait.go:72

Second commit !5 (5bc8f3ba) fix the following issue : (Use "short providerID" as key in the configmap )

2025-08-05T13:27:38Z	ERROR	Unable add provider ID to blacklist	{"controller": "providerIDBlacklist", "controllerGroup": "", "controllerKind": "Node", "Node": {"name":"mgmt-1967295179-rke2-capo-md0-s4qtb-4jb8v"}, "namespace": "", "name": "mgmt-1967295179-rke2-capo-md0-s4qtb-4jb8v", "reconcileID": "10752069-a281-4a9c-b5b9-617c67b4a328", "error": "ConfigMap \"node-provider-id-blacklist\" is invalid: data[openstack:///bffefc8c-82e9-4e93-bc86-e5737f5dcca8]: Invalid value: \"openstack:///bffefc8c-82e9-4e93-bc86-e5737f5dcca8\": a valid config key must consist of alphanumeric characters, '-', '_' or '.' (e.g. 'key.name',  or 'KEY_NAME',  or 'key-name', regex used for validation is '[-._a-zA-Z0-9]+')"}
gitlab.com/sylva-projects/sylva-elements/misc-controllers-suite/internal/controllers/provider-id-blacklist.(*Reconciler).Reconcile
	/workspace/internal/controllers/provider-id-blacklist/provider_id_blacklist.go:59
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.21.0/pkg/internal/controller/controller.go:119
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.21.0/pkg/internal/controller/controller.go:340
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.21.0/pkg/internal/controller/controller.go:300
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.1
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.21.0/pkg/internal/controller/controller.go:202

Detected via pipelines of sylva-projects/sylva-core!4952 (merged)

Edited by Remi Le Trocquer

Merge request reports

Loading