Fix OKD workload cluster circular dependency (!9460) · Merge requests · Sylva-projects / sylva-core

What does this MR do and why?

In CI flavor ☁capm3 🚀rke2|okd 🎬no-update 🛠ha,okd job deploy-workload-cluster the hr/s-u install fails with a circular dependency between the new sylva-system-init unit and openshift-security-context-constraints:

Helm install failed for release okd-capm3-virt/sylva-units with chart sylva-units@0.0.0-git-e6010840+728f288f4999:
execution error at (sylva-units/templates/units.yaml:38:75): unit openshift-security-context-constraints is involved in a circular dependency:
calico-apiserver-rbac -> openshift-security-context-constraints -> sylva-system-init -> openshift-security-context-constraints

Prior to !9410 (diffs) the previously named namespace-defs unit had

# charts/sylva-units/values.yaml
    depends_on:
      # namespace-defs can't depend on Kyverno, because Kyverno depends on
      # some namespaces
      kyverno: false
      kyverno-policies: false
      openshift-security-context-constraints: false

while after the rename to sylva-system-init it has

# charts/sylva-units/workload-cluster.values.yaml
    depends_on:
      # some dependencies of base-deps are inherited, but don't apply here:
      sylva-system-init: false
      calico-ready: false

so openshift-security-context-constraints: false overide, to nullify the base-defs unit template dependency

unit_templates:
  base-deps:
    # we put here the list of base units that most units will need to depend on
    # they correspond to "the workload cluster is ready for stuff to be deployed on it"
    depends_on:
      cluster-reachable: true
      sylva-system-init: true
      calico-ready: '{{ and (tuple . "calico-ready" | include "unit-enabled") (not .Values._internal.state.is_upgrade) }}'
      openshift-security-context-constraints: '{{ eq .Values.cluster.capi_providers.bootstrap_provider "cabpoa" }}'

is missing.

Test coverage

CI configuration

Below you can choose test deployment variants to run in this MR's CI.

Click to open to CI configuration

Legend:

Icon	Meaning	Available values
☁️	Infra Provider	`capd`, `capo`, `capm3`
🚀	Bootstrap Provider	`kubeadm` (alias `kadm`), `rke2`, `okd`, `ck8s`
🐧	Node OS	`ubuntu`, `suse`, `na`, `leapmicro`
🛠️	Deployment Options	Deployment option list and description
🎬	Pipeline Scenarios	Available scenario list and description
🟢	Enabled units	Any available units name, by default apply to management and workload cluster. Can be prefixed by `mgmt:` or `wkld:` to be applied only to a specific cluster type
🔴	Disabled units	Any available units name, by default apply to management and workload cluster. Can be prefixed by `mgmt:` or `wkld:` to be applied only to a specific cluster type
🏗️	Target platform	Can be used to select specific deployment environment Available platform list and description
⚡	Pipeline control	`autorun`, `manual` or `blocking`. Can be used to override global config and start a deployment pipeline the required way

Global config for deployment pipelines

autorun pipelines
allow failure on pipelines
record sylvactl events

Notes:

Enabling autorun will make deployment pipelines to be run automatically without human interaction
Disabling allow failure will make deployment pipelines mandatory for pipeline success.
if both autorun and allow failure are disabled, deployment pipelines will need manual triggering but will be blocking the pipeline

Be aware: after configuration change, pipeline is not triggered automatically. Please run it manually (by clicking the run pipeline button in Pipelines tab) or push new code.

Fix OKD workload cluster circular dependency

What does this MR do and why?

Related reference(s)

Test coverage

CI configuration

Global config for deployment pipelines

Merge request reports