Deploy ClusterSecretStore for reading vault ns Secret/vault-ca and fix secret
What does this MR do and why?
On top of !8620 (merged) fixes observed during testing with an external OpenBao instance serving plain HTTP, two more issues were observed while testing with an external OpenBao serving HTTPS, in !8692 (merged).
I've split this change in a separate MR than !8620 (merged), because it specifically refers to CA certs injection and it does not block plain HTTP external OpenBao code path, but mostly because there are multiple ways to address it (I was initially using this but I think current approach is better, please see sylva-projects/sylva-elements/helm-charts/workload-team-defs!175 (merged)).
The issues and their fixes are:
-
The per-team ESO
SecretStorecreated byworkload-team-defschart in each workload cluster namespace uses Sylva CA to validate external OpenBao TLS, while the external OpenBao CA is not part of that cert/secret.For this, commit 01a9a0f1 creates a new
ClusterSecretStore/eso-store-k8s-vault, to be used for readying vault nsSecret/vault-cain each swct-team-foo ns, using sylva-projects/sylva-elements/helm-charts/workload-team-defs!175 (merged). This newClusterSecretStore/eso-store-k8s-vaultcreation is not conditioned, regardless if it's internal OpenBao or TLS external Openbao it serves the same purpose and it was considered harmless to have it for the plaintext HTTP external OpenBao scenario (would not be used).The
Secret/vault-ca -n vaultis always created:- internal OpenBao, copied from
cert-managerns bykustomize-units/vault/copy-sylva-ca.yaml - external OpenBao, static Secret generated by
kustomize-units/vault-external/components/external-ca/external-ca.yaml, with contents generated from s-u value.security.vault.external_vault_ca.
- internal OpenBao, copied from
-
The
Secret/vault-ca -n vaultholding.security.vault.external_vault_cais written double base64-encoded:- the Kustomize component for external CA of
vault-externalputs theEXT_VAULT_CAvalue instringData - while the unit passes
EXT_VAULT_CAfor substitution already base64-encoded
For this, commit 0fd4fe1c changes from to
Secret.stringDatatoSecret.data, for theSecret/vault-ca -n vaultgeneration. Per https://kubernetes.io/docs/concepts/configuration/secret/#restriction-names-data:The values for all keys in the data field have to be base64-encoded strings. If the conversion to base64 string is not desirable, you can choose to specify the stringData field instead, which accepts arbitrary strings as values.
- the Kustomize component for external CA of
Related reference(s)
Needs to be continued with sylva-projects/sylva-elements/helm-charts/workload-team-defs!175 (diffs).
Test coverage
There is nothing in CI that could exercise the change proposed here.
CI configuration
Below you can choose test deployment variants to run in this MR's CI.
Click to open to CI configuration
Legend:
| Icon | Meaning | Available values |
|---|---|---|
| Infra Provider | capd, capo, capm3 |
|
| Bootstrap Provider | kubeadm (alias kadm), rke2, okd, ck8s |
|
| Node OS | ubuntu, suse, na, leapmicro |
|
| Deployment Options | Deployment option list and description | |
| Pipeline Scenarios | Available scenario list and description | |
| Enabled units | Any available units name, by default apply to management and workload cluster. Can be prefixed by mgmt: or wkld: to be applied only to a specific cluster type |
|
| Disabled units | Any available units name, by default apply to management and workload cluster. Can be prefixed by mgmt: or wkld: to be applied only to a specific cluster type |
|
| Target platform | Can be used to select specific deployment environment Available platform list and description | |
| Pipeline control | autorun, manual or blocking. Can be used to override global config and start a deployment pipeline the required way |
-
🎬 preview☁️ capd🚀 kadm🐧 ubuntu -
🎬 preview☁️ capo🚀 rke2🐧 suse -
🎬 preview☁️ capm3🚀 rke2🐧 ubuntu -
☁️ capd🚀 kadm🛠️ light-deploy🐧 ubuntu -
☁️ capd🚀 rke2🛠️ light-deploy🐧 suse -
☁️ capo🚀 rke2🐧 suse -
☁️ capo🚀 rke2🐧 leapmicro -
☁️ capo🚀 kadm🐧 ubuntu -
☁️ capo🚀 kadm🐧 ubuntu🟢 neuvector,mgmt:harbor -
☁️ capo🚀 rke2🎬 rolling-update🛠️ ha🐧 ubuntu -
☁️ capo🚀 kadm🎬 wkld-k8s-upgrade🐧 ubuntu -
☁️ capo🚀 rke2🎬 rolling-update-no-wkld🛠️ ha🐧 suse -
☁️ capo🚀 rke2🎬 sylva-upgrade🛠️ ha🐧 ubuntu -
☁️ capo🚀 rke2🎬 sylva-upgrade-from-1.6.x🛠️ ha,misc🐧 ubuntu -
☁️ capo🚀 rke2🛠️ ha,misc🐧 ubuntu -
☁️ capo🚀 rke2🛠️ misc🐧 ubuntu🟢 mgmt:harbor🔴 neuvector -
☁️ capo🚀 rke2🛠️ ha,misc,openbao🐧 suse -
☁️ capo🚀 rke2🐧 suse🎬 upgrade-from-prev-tag -
☁️ capm3🚀 rke2🐧 suse -
☁️ capm3🚀 kadm🐧 ubuntu -
☁️ capm3🚀 ck8s🐧 ubuntu -
☁️ capm3🚀 kadm🎬 rolling-update-no-wkld🛠️ ha,misc🐧 ubuntu -
☁️ capm3🚀 rke2🎬 wkld-k8s-upgrade🛠️ ha🐧 suse -
☁️ capm3🚀 kadm🎬 rolling-update🛠️ ha🐧 ubuntu -
☁️ capm3🚀 rke2🎬 upgrade-from-prev-release-branch🛠️ ha🐧 suse -
☁️ capm3🚀 rke2🛠️ misc,ha🐧 suse -
☁️ capm3🚀 rke2🎬 sylva-upgrade🛠️ ha,misc🐧 suse -
☁️ capm3🚀 kadm🎬 rolling-update🛠️ ha🐧 suse -
☁️ capm3🚀 ck8s🎬 rolling-update🛠️ ha🐧 ubuntu -
☁️ capm3🚀 rke2|okd🎬 no-update🐧 ubuntu|na -
☁️ capm3🚀 rke2🐧 suse🎬 upgrade-from-release-1.5 -
☁️ capm3🚀 rke2🐧 suse🎬 upgrade-to-main
Global config for deployment pipelines
- autorun pipelines
- allow failure on pipelines
- record sylvactl events
Notes:
- Enabling
autorunwill make deployment pipelines to be run automatically without human interaction - Disabling
allow failurewill make deployment pipelines mandatory for pipeline success. - if both
autorunandallow failureare disabled, deployment pipelines will need manual triggering but will be blocking the pipeline
Be aware: after configuration change, pipeline is not triggered automatically.
Please run it manually (by clicking the run pipeline button in Pipelines tab) or push new code.