Fix kustomize-units OCI artifact signature (!8199) · Merge requests · Sylva-projects / sylva-core

What does this MR do and why?

🐛 fix: ARTIFACT_DIGEST Variable Handling in tools/oci/build-kustomize-units-artifact.py

Issue

After the refactoring to use from artifact_utils import * (!3494 (merged)), the ARTIFACT_DIGEST variable was always None when passed to the sign() function.

Root Cause

The variable ARTIFACT_DIGEST is modified dynamically at runtime in artifact_utils.py using the global statement by functions like:

artifact_exists_with_flux()
artifact_exists_with_helm()
artifact_exists_with_crane()

When using from artifact_utils import ARTIFACT_DIGEST, Python creates a local copy of the variable at import time (initially None). This local copy is never updated when the module-level variable changes via global statements.

Solution

Changed from:

from artifact_utils import *
sign(artifact_name, ARTIFACT_DIGEST)  # Always None (local copy)

To:

import artifact_utils
from artifact_utils import (...)
sign(artifact_name, artifact_utils.ARTIFACT_DIGEST)  # References module variable

Added warning comment:

# WARNING: ARTIFACT_DIGEST is modified at runtime in artifact_utils module via 'global' statement.
# Must use module reference to get the updated value, not direct import.
sign(artifact_name, artifact_utils.ARTIFACT_DIGEST)

This ensures that sign() receives the actual digest value set by the artifact existence check functions.

Test coverage

CI configuration

Below you can choose test deployment variants to run in this MR's CI.

Click to open to CI configuration

Legend:

Icon	Meaning	Available values
☁️	Infra Provider	`capd`, `capo`, `capm3`
🚀	Bootstrap Provider	`kubeadm` (alias `kadm`), `rke2`, `okd`, `ck8s`
🐧	Node OS	`ubuntu`, `suse`, `na`, `leapmicro`
🛠️	Deployment Options	Deployment option list and description
🎬	Pipeline Scenarios	Available scenario list and description
🟢	Enabled units	Any available units name, by default apply to management and workload cluster. Can be prefixed by `mgmt:` or `wkld:` to be applied only to a specific cluster type
🔴	Disabled units	Any available units name, by default apply to management and workload cluster. Can be prefixed by `mgmt:` or `wkld:` to be applied only to a specific cluster type
🏗️	Target platform	Can be used to select specific deployment environment Available platform list and description
⚡	Pipeline control	`autorun`, `manual` or `blocking`. Can be used to override global config and start a deployment pipeline the required way

Global config for deployment pipelines

autorun pipelines
allow failure on pipelines
record sylvactl events

Notes:

Enabling autorun will make deployment pipelines to be run automatically without human interaction
Disabling allow failure will make deployment pipelines mandatory for pipeline success.
if both autorun and allow failure are disabled, deployment pipelines will need manual triggering but will be blocking the pipeline

Be aware: after configuration change, pipeline is not triggered automatically. Please run it manually (by clicking the run pipeline button in Pipelines tab) or push new code.

Closes #4200 (closed)

Fix kustomize-units OCI artifact signature