Small improvement for interpret-inner-gotpl (!7672) · Merge requests · Sylva-projects / sylva-core

This is a suggestion from Claude Sonnet 4.6 as a side comment during a different topic discussion.

Add a contains "{{" fast-path before the expensive regex in _interpret-inner-gotpl

The regex (.|\n){{(.|\n)+}}(.|\n) is run on every string the traversal touches — including the thousands of already-interpreted strings from the global pass that contain no {{ at all. A simple substring check is faster than the regex engine for the rejection path.
   {{- if regexMatch "(.|\n)*{{(.|\n)+}}(.|\n)*" $data -}}
   {{- if and (contains "{{" $data) (regexMatch "(.|\n)*{{(.|\n)+}}(.|\n)*" $data) -}}
Risk: zero. The contains check is a necessary but not sufficient condition — the regex still validates the full pattern.

Also I removed an unnecessary call to interpret-inner-gotpl in all-unit-dependencies as it is already interpreted in unit_def just above.

Testing it resulted in lowering the time spent by helm template in bootstrap context from 55s to 44s and in management context from 18s to 16s. I know it isn't much, but I believe it's worth it.

CI configuration

Below you can choose test deployment variants to run in this MR's CI.

Click to open to CI configuration

Legend:

Icon	Meaning	Available values
☁️	Infra Provider	`capd`, `capo`, `capm3`
🚀	Bootstrap Provider	`kubeadm` (alias `kadm`), `rke2`, `okd`, `ck8s`
🐧	Node OS	`ubuntu`, `suse`, `na`, `leapmicro`
🛠️	Deployment Options	Deployment option list and description
🎬	Pipeline Scenarios	Available scenario list and description
🟢	Enabled units	Any available units name, by default apply to management and workload cluster. Can be prefixed by `mgmt:` or `wkld:` to be applied only to a specific cluster type
🔴	Disabled units	Any available units name, by default apply to management and workload cluster. Can be prefixed by `mgmt:` or `wkld:` to be applied only to a specific cluster type
🏗️	Target platform	Can be used to select specific deployment environment Available platform list and description
⚡	Pipeline control	`autorun`, `manual` or `blocking`. Can be used to override global config and start a deployment pipeline the required way

Global config for deployment pipelines

autorun pipelines
allow failure on pipelines
record sylvactl events

Notes:

Enabling autorun will make deployment pipelines to be run automatically without human interaction
Disabling allow failure will make deployment pipelines mandatory for pipeline success.
if both autorun and allow failure are disabled, deployment pipelines will need manual triggering but will be blocking the pipeline

Be aware: after configuration change, pipeline is not triggered automatically. Please run it manually (by clicking the run pipeline button in Pipelines tab) or push new code.

Small improvement for interpret-inner-gotpl

CI configuration

Global config for deployment pipelines

Merge request reports