sylva-units optimization (use "pass result by reference" for call to "all-unit-dependencies") (!7425) · Merge requests · Sylva-projects / sylva-core

This MR is a small evolution changing how the "all-unit-dependencies" named template is called.

This template is called:

once to compute cluster_machines_ready_unit_deps (result currently returned as JSON)
one time per unit, to check against dependency loops (result returned as JSON, but not used)

This MR does a simple optimization: instead of calling all-unit-dependencies which produces JSON, it calls _all-unit-dependencies which receives a $result dict and stores the result in this dict. This "pass by reference" trick allows to avoid the production of JSON string, and the corresponding call to toJson.

After this change the original all-unit-dependencies is not used anymore, and hence I removed it to only keep one, named all-unit-dependencies, which supports only the "pass by reference" calling convention.

This MR does another change: it defines $all_dependencies_cache earlier and passes it to the first call to all-unit-dependencies, to have more calls benefit from this cache.

Overall this MR brings a measurable improvement (my benchmark is a helm template using values from my CAPO dev mgmt cluster):

runtime: 15-20% improvement (for instance from 19.6s to 16.6s)
peak memory: a ~5-10% improvement (from 1299480 Ki to 1105780 Ki)

CI configuration

Below you can choose test deployment variants to run in this MR's CI.

Click to open to CI configuration

Legend:

Icon	Meaning	Available values
☁️	Infra Provider	`capd`, `capo`, `capm3`
🚀	Bootstrap Provider	`kubeadm` (alias `kadm`), `rke2`, `okd`, `ck8s`
🐧	Node OS	`ubuntu`, `suse`, `na`, `leapmicro`
🛠️	Deployment Options	Deployment option list and description
🎬	Pipeline Scenarios	Available scenario list and description
🟢	Enabled units	Any available units name, by default apply to management and workload cluster. Can be prefixed by `mgmt:` or `wkld:` to be applied only to a specific cluster type
🔴	Disabled units	Any available units name, by default apply to management and workload cluster. Can be prefixed by `mgmt:` or `wkld:` to be applied only to a specific cluster type
🏗️	Target platform	Can be used to select specific deployment environment (i.e `real-bmh` for capm3 )

Global config for deployment pipelines

autorun pipelines
allow failure on pipelines
record sylvactl events

Notes:

Enabling autorun will make deployment pipelines to be run automatically without human interaction
Disabling allow failure will make deployment pipelines mandatory for pipeline success.
if both autorun and allow failure are disabled, deployment pipelines will need manual triggering but will be blocking the pipeline

Be aware: after configuration change, pipeline is not triggered automatically. Please run it manually (by clicking the run pipeline button in Pipelines tab) or push new code.

Edited Apr 01, 2026 by Thomas Morin

sylva-units optimization (use "pass result by reference" for call to "all-unit-dependencies")

CI configuration

Global config for deployment pipelines

Merge request reports