remove useless problematic legacy transitional code for coredns (kubeadm)
The main motivation for this MR is that it is required in the context of !6589 (merged) to solve
Indeed !4777 (merged) did something particular to avoid deploying the coredns Helm chart on kubeadm: it makes the HelmRelease conditionally suspended in that case. This was done like this to handle the Sylva 1.3-to-1.4 transition smoothly. But keeping doing that is incompatible with solving #3377 (closed).
This transition code is worth cleaning up and simplifying: after this MR, on kubeadm the coredns unit, instead of being a suspended HelmRelease, will simply be absent. This is the typecleanup aspect of this MR.
The less-nice thing is that, the coredns Kustomization if not enabled anymore would be deleted by the helm-controller, but that would be prevented by the avoid-delete-mgmt-resources-flux Kyverno policy, which protects a few base units... to overcome that, this MR adds a pre-upgrade hook that will unprotect and delete the coredns Kustomization if the coredns unit shouldn't be active but the Kustomization exists.
CI configuration
Below you can choose test deployment variants to run in this MR's CI.
Click to open to CI configuration
Legend:
| Icon | Meaning | Available values |
|---|---|---|
| Infra Provider | capd, capo, capm3 |
|
| Bootstrap Provider | kubeadm (alias kadm), rke2, okd, ck8s |
|
| Node OS | ubuntu, suse, na, leapmicro |
|
| Deployment Options | light-deploy, dev-sources, ha, misc, maxsurge-0, logging, no-logging, cilium |
|
| Pipeline Scenarios | Available scenario list and description | |
| Enabled units | Any available units name, by default apply to management and workload cluster. Can be prefixed by mgmt: or wkld: to be applied only to a specific cluster type |
|
| Target platform | Can be used to select specific deployment environment (i.e real-bmh for capm3 ) |
-
🎬 preview☁️ capd🚀 kadm🐧 ubuntu -
🎬 preview☁️ capo🚀 rke2🐧 suse -
🎬 preview☁️ capm3🚀 rke2🐧 ubuntu -
☁️ capd🚀 kadm🛠️ light-deploy🐧 ubuntu -
☁️ capd🚀 rke2🛠️ light-deploy🐧 suse -
☁️ capm3🚀 rke2🐧 suse -
☁️ capo🚀 rke2🐧 leapmicro -
☁️ capm3🚀 kadm🐧 ubuntu -
☁️ capo🚀 kadm🐧 ubuntu🟢 neuvector,mgmt:harbor -
☁️ capo🚀 rke2🎬 rolling-update🛠️ ha🐧 ubuntu -
☁️ capo🚀 kadm🎬 sylva-upgrade🔴 harbor🐧 ubuntu -
☁️ capo🚀 rke2🎬 rolling-update-no-wkld🛠️ ha🐧 suse -
☁️ capm3🚀 rke2🎬 sylva-upgrade🛠️ ha🐧 ubuntu -
☁️ capm3🚀 kadm🎬 sylva-upgrade🛠️ ha🐧 ubuntu -
☁️ capo🚀 rke2🎬 sylva-upgrade-from-1.6.x🛠️ ha,misc🐧 ubuntu -
☁️ capo🚀 rke2🛠️ ha,misc🐧 ubuntu -
☁️ capo🚀 rke2🛠️ ha,misc,openbao🐧 suse -
☁️ capo🚀 rke2🐧 suse🎬 upgrade-from-prev-tag
Global config for deployment pipelines
- autorun pipelines
- allow failure on pipelines
- record sylvactl events
Notes:
- Enabling
autorunwill make deployment pipelines to be run automatically without human interaction - Disabling
allow failurewill make deployment pipelines mandatory for pipeline success. - if both
autorunandallow failureare disabled, deployment pipelines will need manual triggering but will be blocking the pipeline
Be aware: after configuration change, pipeline is not triggered automatically.
Please run it manually (by clicking the run pipeline button in Pipelines tab) or push new code.