Update values files based on cluster type

What does this MR do and why?

This MR implement a new logic when we try to update CI values files.

It will first try to find if the file passed as argument exists, if yes it will apply it and his cluster-type prefixed version

  • <file>.yml
  • <cluster-prefix>-<file>.yml else it check for the file in SYLVA_CI_VALUES_FOLDER with the following order:
  • common/<file>.yml
  • common/<cluster-prefix>-<file>.yml
  • <versioned-folder>/<file>.yml
  • <versioned-folder>/<cluster-prefix>-<file>.yml

Example (local test on my laptop with dummy files)

./update-values.sh all-ci-deployments.yml ha.yml serve-sylva-n-1-1.31-32.yaml          
management cluster detected, applying mmgmt prefix
Applying values from ci-deployment-values/common/all-ci-deployments.yml to test-values.yml
Applying values from ci-deployment-values/common/mgmt-all-ci-deployments.yml to test-values.yml
Applying values from ci-deployment-values/current/all-ci-deployments.yml to test-values.yml
Applying values from ci-deployment-values/current/mgmt-all-ci-deployments.yml to test-values.yml
Applying values from ci-deployment-values/common/ha.yml to test-values.yml
Applying values from ci-deployment-values/current/serve-sylva-n-1-1.31-32.yaml to test-values.yml

To reduce code duplicate I put the update part in a dedicated function.

This would both solve the problem mentioned in sylva-projects/sylva-elements/ci-tooling/ci-deployment-values#19 (closed) and allow to clean the code exception for some options like theses:

        misc)
          case "$DEPLOYMENT_INFRA_PROV-$CLUSTER_TYPE" in
            capo-management)
              update_values_file misc-units-in-capo.yml
              ;;
            capo-workload)
              update_values_file misc-units-in-capo-wkld.yml
              ;;
            capm3-management)
              update_values_file misc-units-in-capm3.yml
              ;;
            capm3-workload)
              update_values_file misc-units-in-capm3-wkld.yml
              ;;
          esac
          ;;
        okd-wkld)
          if [[ "$CLUSTER_TYPE" == "management" ]]; then
            update_values_file okd.yml
          elif [[ "$CLUSTER_TYPE" == "workload" ]]; then
            update_values_file okd-wkld.yml
          fi
          ;;

^ okd case can be solved just by renaming the values files ^ misc can be solved just by renaming the values files and use the same for both infra (which should have done long time ago I think)

close sylva-projects/sylva-elements/ci-tooling/ci-deployment-values#19 (closed)

Test coverage

CI configuration

Below you can choose test deployment variants to run in this MR's CI.

Click to open to CI configuration

Legend:

Icon Meaning Available values
☁️ Infra Provider capd, capo, capm3
🚀 Bootstrap Provider kubeadm (alias kadm), rke2, okd, ck8s
🐧 Node OS ubuntu, suse, na, leapmicro
🛠️ Deployment Options light-deploy, dev-sources, ha, misc, maxsurge-0, logging, no-logging, cilium
🎬 Pipeline Scenarios Available scenario list and description
🟢 Enabled units Any available units name, by default apply to management and workload cluster. Can be prefixed by mgmt: or wkld: to be applied only to a specific cluster type
🏗️ Target platform Can be used to select specific deployment environment (i.e real-bmh for capm3 )
  • 🎬 preview ☁️ capd 🚀 kadm 🐧 ubuntu

  • 🎬 preview ☁️ capo 🚀 rke2 🐧 suse

  • 🎬 preview ☁️ capm3 🚀 rke2 🐧 ubuntu

  • ☁️ capd 🚀 kadm 🛠️ light-deploy 🐧 ubuntu

  • ☁️ capd 🚀 rke2 🛠️ light-deploy 🐧 suse

  • ☁️ capo 🚀 rke2 🐧 suse

  • ☁️ capo 🚀 rke2 🐧 leapmicro

  • ☁️ capo 🚀 kadm 🐧 ubuntu

  • ☁️ capo 🚀 kadm 🐧 ubuntu 🟢 neuvector,mgmt:harbor

  • ☁️ capo 🚀 rke2 🎬 rolling-update 🛠️ ha 🐧 ubuntu

  • ☁️ capo 🚀 kadm 🎬 wkld-k8s-upgrade 🐧 ubuntu

  • ☁️ capo 🚀 rke2 🎬 rolling-update-no-wkld 🛠️ ha 🐧 suse

  • ☁️ capo 🚀 rke2 🎬 sylva-upgrade-from-1.5.x 🛠️ ha 🐧 ubuntu

  • ☁️ capo 🚀 rke2 🎬 sylva-upgrade-from-1.5.x 🛠️ ha,misc 🐧 ubuntu

  • ☁️ capo 🚀 rke2 🛠️ ha,misc 🐧 ubuntu

  • ☁️ capo 🚀 rke2 🛠️ ha,misc,openbao🐧 suse

  • ☁️ capo 🚀 rke2 🐧 suse 🎬 upgrade-from-prev-tag

  • ☁️ capm3 🚀 rke2 🐧 suse

  • ☁️ capm3 🚀 kadm 🐧 ubuntu

  • ☁️ capm3 🚀 ck8s 🐧 ubuntu

  • ☁️ capm3 🚀 kadm 🎬 rolling-update-no-wkld 🛠️ ha,misc 🐧 ubuntu

  • ☁️ capm3 🚀 rke2 🎬 wkld-k8s-upgrade 🛠️ ha 🐧 suse

  • ☁️ capm3 🚀 kadm 🎬 rolling-update 🛠️ ha 🐧 ubuntu

  • ☁️ capm3 🚀 rke2 🎬 sylva-upgrade-from-1.5.x 🛠️ ha 🐧 suse

  • ☁️ capm3 🚀 rke2 🛠️ misc,ha 🐧 suse

  • ☁️ capm3 🚀 rke2 🎬 sylva-upgrade-from-1.5.x 🛠️ ha,misc 🐧 suse

  • ☁️ capm3 🚀 kadm 🎬 rolling-update 🛠️ ha 🐧 suse

  • ☁️ capm3 🚀 ck8s 🎬 rolling-update 🛠️ ha 🐧 ubuntu

  • ☁️ capm3 🚀 rke2|okd 🎬 no-update 🐧 ubuntu|na

  • ☁️ capm3 🚀 rke2 🐧 suse 🎬 upgrade-from-release-1.5

  • ☁️ capm3 🚀 rke2 🐧 suse 🎬 upgrade-to-main

Global config for deployment pipelines

  • autorun pipelines
  • allow failure on pipelines
  • record sylvactl events

Notes:

  • Enabling autorun will make deployment pipelines to be run automatically without human interaction
  • Disabling allow failure will make deployment pipelines mandatory for pipeline success.
  • if both autorun and allow failure are disabled, deployment pipelines will need manual triggering but will be blocking the pipeline

Be aware: after configuration change, pipeline is not triggered automatically. Please run it manually (by clicking the run pipeline button in Pipelines tab) or push new code.

Edited by Loic Nicolle

Merge request reports

Loading