fix RBAC for CAPI cluster-garbage-collector CronJob, for OKD

Thomas Morinrequested to merge
fix-capi-garbage-cleanup-rbac into main

This MR fixes a small regression introduced by !3383 (merged): the CRD name for the OKD controlplane/bootstrap provider hadn't been updated in the RBAC role definition for the CAPI cluster-garbage-collector CronJob.

This was breaking the CI job checking the CronJobs:

KO: Job cluster-garbage-collector-test-df2cdb20 for cronjob cluster-garbage-collector in namespace sylva-system did not complete successfully within timeout.
KO: Job cluster-garbage-collector-test-df2cdb20 for cronjob cluster-garbage-collector in namespace sylva-system did not complete successfully within timeout.

https://gitlab.com/sylva-projects/sylva-core/-/jobs/8572557643#L121

This MR fixes this issue.

It also replaces some explicit list of resources by wildcards for list/get verbs, to have less such future updates to do. I kept explicit list of resources for delete verb because it seems more secure do not use wildcards for such actions.

Edited by Thomas Morin

Merge request reports