Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • RediStack RediStack
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 30
    • Issues 30
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Swift on Server CommunitySwift on Server Community
  • RediStackRediStack
  • Merge requests
  • !156

Draft: Allow the scan test to accept a range of result counts.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Peter Adams requested to merge PeterAdams-A/RediStack:scantestrange into master May 11, 2021
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

The scan test has been unreliable.

Expected Results

Scan test to always pass in various environments.

Actual Results

Test sometimes fails.

Steps to Reproduce

  1. Examine recent CI runs.

Background

The scan test has been unreliable due to differences in returned sizes. The requested count is only advisory, the server may ignore and return an alternative count. See discussion on #23 (comment 567176355)

Accept a count in the range 6-9 when requesting 8.

Checklist:

  • Copyright headers in new files (see CONTRIBUTING.md)
  • Unit test case to prevent the bug in the future
Edited May 11, 2021 by Peter Adams
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: scantestrange