Skip to content

Get scan working the same as redis-cli 6.2.1

Peter Adams requested to merge PeterAdams-A/RediStack:scan into master

The SCAN command does not work the same as Redis-cli 6.2.1

If the bug being fixed has an issue written

Related to https://gitlab.com/Mordil/RediStack/-/issues/23

If the bug being fixed does NOT have an issue written

Expected Results

The SCAN commands parameters should work correctly rather than return an error.

Actual Results

Error was previously returned.

Steps to Reproduce

  1. Run the unit test I have uncommented - I had to change to use scanKeys instead of scan.

Notes

I have only tested this against the version of redis I have - I assume the version that already exists must work against some other version of redis which I will probably have broken.

I derived my change by wiresharking Redis-cli 6.2.1 and seeing what looked different.

I have not changed the test which is marked as flaky in issue 23. I don't obviously spot what will be flaky, it seems quite generous on what results it will accept as valid - I've run it a fair few times locally and it always passed for me.

Checklist:

  • Copyright headers in new files (see CONTRIBUTING.md)
  • Unit test case to prevent the bug in the future

Merge request reports