Skip to content

bugfix for download_file

Dave LeFevre requested to merge (removed):master into master

There is a bug in download_file that shows up if SALI_VERBOSE_LEVEL=256.

The captured output from download_file is expected to be the name of the file, however the if statement when the verbose level is set to 256 sets rsync to be verbose so the output captured is from rsync, not the download_file function. That means "receiving incremental file list" is actually captured when SALI_VERBOSE_LEVEL is high. It also is captured without a trailing tick mark so the entire sali imaging run fails and doesn't even fall to a shell.

I did not try this with curl but the same problem would happen there as well if there was any output created.

This patch removes the if statement and sends the output for rsync and curl downloads to /dev/null. Another solution might be to use p_comment to output something to the terminal like "downloading script" when SALI_VERBOSE_LEVEL is high but I did not do that in this patch.

Edited by Dave LeFevre

Merge request reports