Skip to content

WIP : Text notes

Tristan Le Granché requested to merge text_notes into develop

Checklist

Please check if your MR fulfills the following requirements:

  • Unit tests have been added, if needed
  • Documentation have been updated, if needed
  • Build was run locally and any changes were pushed
  • Lint has passed locally without error
  • Package.py have been updated, if needed
  • CHANGELOG.md have been updated, if needed
  • Version numer has been tagged, if needed

Merge request type

Please check the type of change your MR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Breaking change?

  • Yes
  • No

Summary

  • Add reply system to TextNote and note.json files
  • Add an update system in orv_add_notes to allow the linker or the reply system to add data to orv notes
  • Keep a track of the text notes y position to keep the same position on update
    • Avoid the text notes to go back to start position on some events

Description of change

  • Still need to find a way to avoid update bug when text notes are displayed.

How to test it

Review

  • Assigned To: @Tilix4
  • Expected review time: 2 days
  • FYI: @awesome_dev_too

Merge request reports