Skip to content

WIP : Bugfix & better user feedbacks

Tristan Le Granché requested to merge strangenoise/stax:bugfix into develop

Waiting for another bugfix

Checklist

Please check if your MR fulfills the following requirements:

  • Unit tests have been added, if needed
  • Documentation have been updated, if needed
  • Build was run locally and any changes were pushed
  • Lint has passed locally without error
  • Package.py have been updated, if needed
  • CHANGELOG.md have been updated, if needed
  • Version numer has been tagged, if needed

Merge request type

Please check the type of change your MR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Breaking change?

  • Yes
  • No

Summary

Small bugfixs and feedbacks for the user

Description of change

  • Add an icon to the show/hide annotation to let the user know the state.
  • Pass clip object instead of clip.name to get_webpage_url

How to test it

Change annotations show/hide.

Review

  • Assigned To: @awesome_dev
  • Expected review time: 2 days
  • FYI: @awesome_dev_too
Edited by Tristan Le Granché

Merge request reports