Skip to content

Get text notes from linker and other stuffs

Tristan Le Granché requested to merge strangenoise/stax:text_notes_from_linker into text_notes

New features:

  • Get text notes from linker
  • Reload text notes display on several events to always display the wanted text data.
  • Disable display on animation_is_playing to avoid frame rate drop and have a better visibility on shots.
  • Add functional reply system
  • Reply system updates display text notes

Whats new for orv_note and on the linker side ?

  • Add a replies attributes in the ORV notes passed to orv_add_note by the linker.
  • Replies contains a list of dict with the "name", "time" and "body" attributes, used by the display text notes operator to show author, date and message.

What's wrong ?

  • Text notes are not updated on a simple update. Need to discuss about that.

Why have I done that before OpenReview is finished ?

  • Some of the features are not OpenReview related so the whole text note system as been improved
  • OpenReview and linker related features were pretty quick to do. So we've got a first functional version that will need a bit of refactor when ORV will be implemented.

Need !52 (merged) to be merged before. Closes #5 (closed)

Edited by Félix David

Merge request reports