Skip to content
Snippets Groups Projects

Fix deep diff comparison of GObjects

Merged Cesar Enrique Garcia requested to merge cquike/sublime-music:fix_deepdiff into master
All threads resolved!

This is a fix for issue #340 (closed). After some investigation, it turns out that the deep diff functionality is not working properly with classes that derive from GObject. This is because at some point the props attribute is inspected by deepdiff and it tries to get the class using class. However, the attribute props contains a list of GObject properties that don't contain the attribute class. Whether that's a bug in Gtk or intentionally is unclear to me. The fix is to ignore the comparison of the props attribute. Note that the object to compare already contains named attributes with the values to compare, so comparing also .props is kind of redundant. Although the issue #340 (closed) referred to playlist the issue was actually also present in the artist and browse views.

Edited by Cesar Enrique Garcia

Merge request reports

Checking pipeline status.

Approved by

Merged by Sumner EvansSumner Evans 2 years ago (Aug 18, 2022 6:11pm UTC)

Merge details

Pipeline #628288149 failed

Pipeline failed for b9284f90 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sumner Evans resolved all threads

    resolved all threads

  • added 1 commit

    • 05f3cdf2 - Fix deep diff comparison of GObjects

    Compare with previous version

  • Sumner Evans resolved all threads

    resolved all threads

  • Sumner Evans approved this merge request

    approved this merge request

  • Sumner Evans mentioned in commit b9284f90

    mentioned in commit b9284f90

  • merged

  • mentioned in issue #340 (closed)

  • mentioned in issue #345 (closed)

  • Please register or sign in to reply
    Loading