Skip to content

Various async music mode bug fixes

Alex requested to merge alexyao2015/python-yeelight:fix-music into master

Prevents sending false disconnect callbacks when entering/exiting music mode.

The connection will knowingly drop when:

  • The light is turned off
  • When sending a request to enable music mode

Issues resolved:

  • Fixes a bug where music mode doesn't successfully connect and it resulted in a "connected" state while having no write socket.
  • Fixes an issue where music mode is activated twice in rapid succession resulting in hang.
  • Fixes an issue where music mode reconnect will fail if obtaining properties fails.
  • Fixes an issue where music mode is connecting while another command is being ran, resulting in a hang until the command response times out

Removes automatic music mode reconnect when light is turned off. This requires turning on music mode whenever the light is turned back on, but this provides the benefit of being able to update the properties on turn on. Enabling music mode when the device is off doesn't make sense anyways.

Edited by Alex

Merge request reports