Skip to content

ux: fix placement of mentions input in certain cases

Andrew Chou requested to merge ac/1804/mentions-insert-bug into master

Addresses #1804 (closed)

Notes:

  • Created a new reducer that properly updates the postTextSelection state on selection change events. Wasn't entirely sure if one of the existing reducers should do this, so I'm fully prepared to update this MR as needed in that case
  • The variable names for the relevant mentions reducer were incredibly confusing (using "post" to mean "after" but also the entity 😄), so I updated the variable names to be a little clearer
  • Said reducer also was using a deprecated string method substr, which I updated to substring which has minimal effect in this case

Preview:

1804-mentions-placement

Merge request reports