Skip to content

AT5-594 obs state commands

Taylor Huang requested to merge at5-594-obsState-commands into master

The mid-cbf-mcs VCC, FSP PSS mode and and FSP CORR mode configuration capabilities have been updated to support all observing states, the correct transitions and triggering commands as follows:

1 - Updated to the VCC Tango device class to inherit from the CspSubElementObsDevice base class (rather then from the SAKCapability class) and using the base classes command definition paradigm, ensuring in this way that the observing state state machine as well as the commands that trigger them can be inherited; all the ad-hoc obState changes have been removed.

2 - Updated the subordinate 4 VCC_Band* device classes and the VccSearchWindow class to use the InitCommand() class (instead of init_device()) and remove the local SetState() functions.

3 - Updated, in a similar way to the Vcc, the FspCorrSubarray and FspPssSubarray Tango device classes.

4 - Eliminated one level of the client-server hierarchy of tango classes, namely the CbfSubarrayCorrConfig and CbfSubarrayPssConfig classes and moved their functionality to CbfSubarry. In this way scan configuration for the Correlation and PSS modes will be done in one place (FspCorrSubarray and FspPssSubarry class respectively).

5 - Updated the CbfSubarray class to support all the obsState Vcc an Fsp updates.

6- Updated pytest testing classes to support the new implementation.

Edited by Taylor Huang

Merge request reports