Skip to content

CIP-1726 Refactor MCS abort/reset/restart path

Taylor Huang requested to merge cip-1726-abort-reset-restart into main

Description:

Refactor MCS abort/reset/restart path.

Details:

For full details, see CIP-1726.

Changes were made to:

  • subarray_component_manager:
    • refactored the abort and deconfigure commands
    • integration test (CbfSubarray_test) was also updated and refactored
      • abort tests were added
      • fault testing was also added for the following cases:
        • FAULT->restart->EMPTY
        • FAULT->obsreset->IDLE

The following FSP subelements were modified, including refactoring the unit and integration tests to handle the new abort() implementation.

  • fsp_corr
  • fsp_pst
  • fsp_pss

For the FSP, this included modifications to the component manager as well as the device file. The device file calls on the component manager to implement the abort; note that the abort is not fully implemented as it is waiting for the HPS implementation.

For the VCC, abort and obsreset were modified to handle an edge case, integration and unit tests were also modified.

Edited by Elizabeth Pieters

Merge request reports