Skip to content

CIP-1606 validate telmodel commands

Tara Kong requested to merge cip-1606-validate-telmodel-commands into main

Part 2 of story: https://jira.skatelescope.org/browse/CIP-1749

Added validation against the telescope model from the MCS, for the following test parameters

  • delay_models
  • configure_scan - currently the test will NOT fail if validation fails, in order to accommodate the outdated but not-yet-used fields including: search_window, PSS-BF, and PST-BF. To be resolved in future work (TBD)
  • scan - currently being skipped as of CIP-1728. To be resolved in CIP-1732

Debugging the integration tests was difficult when I first tried to modify the configure_scan jsons in tests/data/ to make them compliant, so I added a bunch of debug logs to help in the future, for when the configure_scan jsons are made compliant and the ConfigureScanCommand code and integration tests are modified accordingly.

Edited by Tara Kong

Merge request reports