Skip to content

TOP-1397: Fixes for correlator recovery workaround

Deneys Maartens requested to merge top-1397-rework-routing into main

This contains multiple fixes around the correlator recovery workaround, plus some outstanding tech debt:

  1. Folds in the P4 Routing Plugin into the Output Capture plugin. The previous implementation caused an issue when running a pipeline after a fresh deployment, because the P4 Routing Plugin would attempt to read a CNIC FPGA serial number before it was available.
  2. A separate session-scoped auto-use plugin is created for the PTP routes, so that this is only applied once per pipeline run.
  3. The correlator ready/reset plugins have been refactored so that they each serve a specific purpose. This makes the LowCbfProcessorReadyPlugin suitable for extension once we start using different firmware versions.
  4. Fixed a bug with the configuration timer where it was measuring the configuration time of each processor in series, while they are programming in parallel. This caused some measurements to become 0, skewing the average across the session.
  5. Correlators are now reset before every scan instead of after flashing the firmware. This should not cause any issues according to Perentie and should ensure that the reset happens after the firmware was loaded during configuration.
  6. The correlator recovery workaround is now only performed for tests that actually use the data path. This should shave off a bit of runtime from the pipeline.
Edited by Sander Ploegsma

Merge request reports