Skip to content

DPPT-648: Implement full admin mode model and remove controller commands

Mark Ashdown requested to merge dppt-648-state-model into master

Update the controller and subarray state models. The devices now implement the full writable admin mode model. Not all of the values are appropriate for a software-only system like the SDP, but it may be useful to indicate that the system or a subarray is not to be used for normal operations.

Controller

The controller is not controlling any hardware, so it does not make sense for it to have commands to change the state. This removes the commands and initialises the device in the "ON" state. The state remains "ON", unless the admin mode is set to "OFFLINE", "NOT_FITTED" or "RESERVED", in which case the state is "DISABLE" (sic).

Now the only internal state the controller needs to store in the configuration database is its admin mode.

Subarray

The subarray now reports the state as its commanded state, unless the admin mode is set to "OFFLINE", "NOT_FITTED" or "RESERVED", in which case the state is "DISABLE".

The interface to the subarray state in the configuration database has been modified to store the commanded state (state_commanded) and the commanded observing state (obs_state_commanded, previously called obs_state_target). The actual values reported on the attributes may be a transitional or faulty values depending on the state of the system, or be overridden by the admin mode. Eventually the commanded values will need to be reported too (see SP-3868).

Merge request reports