Skip to content

SP-1434 Another attempt at implementing watcher stop safely

Peter Wortmann requested to merge fix-watcher-stop-more into master

Two things might be happening here:

  1. We stop the watcher before it has actually created the response object. So if the thread doesn't join immediately, we should re-try whether a resp object has been created that we could close

  2. Closing the resp object immediately after closing the connection is likely a bad idea - the first step should already wake up the watcher thread, at which point there could be all kinds of interactions. So better first attempt to join the thread before we try any of the more destructive methods.

Merge request reports