Skip to content

Feature optional auth

Ben Ashley requested to merge feature--optional-auth into develop

First pass at making authentication optional. Points to highlight:

  • If the AUTH_SERVER_URL is empty (technically if it's falsey) it's assumed authentication is switched off. However, this meant changing how the default AUTH_SERVER_URL works by removing the default. We could either leave it like this and let people know they need to set it, or potentially use a different value like DISABLED to indicate it's disabled.
  • I haven't added much extra dependency on recompose, but I haven't removed it either, so that might not be okay.
  • If authentication is disabled, I dispatch the AUTHENTICATED event (which I think is probably misnamed) to indicate that we're not currently attempting a connection to keycloak (as represented by the getIsAuthenticating method), otherwise we freeze on page load with the spinner. Another option could be to alter the getIsAuthenticating function to always return false if authentication is disabled.

#320 (closed)

Edited by Nicolas Briemant

Merge request reports