fixed version-printout and flags print-out
fixed version-printout and flags print-out
The print-out of version, libraries and flags has been updated.
The Src/SIESTA_cmake_vgen.sh script has been renamed to Tools/version_generate.sh
The SIESTA prefix is superfluous, and the placement is now better.
The build for the various version implementations are now much simpler, and should not require any copying of files (which can be error-prone). Utilites who wants to write out a version and associated flags/ppflags can now follow the quite simple recipe in the TS/TBtrans utility.
It boils down to a couple of things:
- translating the FLAGS into a string
- extracting the FPPFLAGS for the executable (not all gathering)
- translate the FPPFLAGS into a string
- configure_file the Src/version-info-template.inc into the current utility's binary-dir
- add the binary-dir to the include directories
The above will only use the siesta-used files for everything. So no code duplication etc. One could argue that it should be done in a library. However, the different utilities may use different compile definitions, hence different capabilities. For now, I think this is the simplest, yet very effective way to propagate how its shown to all utilities.
All uncessesary files have been deleted.
The Docs/{release.sh,Makefile} are updated to respect this change as well.
As for the building, now Siesta prints out the error messages a bit more stricter, with some more clear indication of how it interprets the versions.
This fixes #353 (closed), #355 (closed).
Signed-off-by: Nick Papior nickpapior@gmail.com
Details
Please detail what this MR introduces
-
Describe in details what this MR does? (link to the issue by writing # here) -
Does this MR change the behaviour of any fdf-flags? If so, ensure this is documented in the manual -
If new fdf-flags are added, please add thorough descriptions to the manual -
add a summary sentence in the ReleaseNotes.md file -
if this breaks compatibility, add mentions to the Docs/compatibility.tex