Skip to content

Resolve "CS shower crashes with "Invalid color flow" in single-top setup"

Enrico Bothmann requested to merge 557-cs-shower-crashes-with-invalid-color-flow-in-single-top-setup into master

Description

Fix #557 (closed), by moving the forced decay rejection (due to number of failed attempts) into Sudakov.C. This way, the failure is reported (= false is returned) before the flavour information of the winning splitting in Shower.C is overwritten.

Test Plan

This is so rare that it's difficult to reproduce. However, for me a crash as reported in #557 (closed) was a deterministic outcome for a given event. The fix removes that crash, but obviously it's hard to do a conclusion, because of the MCMC nature of the problem. However, the fix seems sane to me at least.

Example Result

no crash, see #557 (closed)

Additional Checklist Items

  • I have updated documentation as needed -> none needed
  • I considered if this should be cherry-picked/ported somewhere else (rel-2-x or master), and if yes, opened a corresponding issue or MR -> There are no forced decay on rel-2-x, so a similar logic issue can't exist there

Closes #557 (closed)

Merge request reports