remove accidental c++11 dependency
All threads resolved!
All threads resolved!
Description
Removing the accidental c++11 dependency. By using the explicit double min/max values. This is exactly the same behaviour as before, c.f. https://en.cppreference.com/w/cpp/types/numeric_limits/lowest
Additional Checklist Items
-
I have updated documentation as needed: not needed -
I considered if this should be cherry-picked/ported somewhere else (rel-2-x or master), and if yes, opened a corresponding issue or MR: not needed
Merge request reports
Activity
changed milestone to %rel-2-2-15
added build-system minor labels
requested review from @ebothmann and @fsiegert
assigned to @max.knobbe
mentioned in issue #486 (closed)
- Resolved by Enrico Bothmann
Looks perfect. Since it's release, I also read the cppreference documentation you refer to, and your change should indeed give the exact same behaviour as before.
However, I would put the
#include <cfloat>
into the.C
file, such that not all files including the.H
also have to include that<cfloat>
header.
Please register or sign in to reply