Skip to content

Add an underscore to all ffi functions.

Neal H. Walfield requested to merge neal/rename-ffi into main

  • When rpm is configured to use Sequoia for the OpenPGP implementation ('configure --crypto=sequoia'), librpmio is linked against librpm_sequoia.

    • librpm_sequoia can't directly implement the OpenPGP API, because librpmio won't reexport librpm_sequoia's symbols, and we don't want a program linking against librpmio to explicitly link against (i.e., need a DT_NEEDED entry for) librpm_sequoia.

    • We can circumvent this problem by having librpm_sequoia provide identical functions under different names, and then having librpmio provide forwarders. This commit renames pgpFoo to _pgpFoo.

    • See https://github.com/rpm-software-management/rpm/issues/2051 .

Merge request reports